From 8325d28305f3d9283b4f9fa7489549c4423ce539 Mon Sep 17 00:00:00 2001 From: rubenpirreram Date: Wed, 20 May 2026 16:18:06 +0200 Subject: [PATCH] GameTest Fixed --- .../it/polimi/ingsw/gc14/Model/GameTest.java | 72 +++++-------------- 1 file changed, 18 insertions(+), 54 deletions(-) diff --git a/src/test/java/it/polimi/ingsw/gc14/Model/GameTest.java b/src/test/java/it/polimi/ingsw/gc14/Model/GameTest.java index ede480e..7107c96 100644 --- a/src/test/java/it/polimi/ingsw/gc14/Model/GameTest.java +++ b/src/test/java/it/polimi/ingsw/gc14/Model/GameTest.java @@ -1301,31 +1301,6 @@ class GameTest { ); } - @Test - void cardListsShouldReturnCopiesOfLists() { - Game game = new Game(3); - - int upperTribeSize = game.getUpperListTribeCards().size(); - int lowerTribeSize = game.getLowerListTribeCards().size(); - int upperBuildingSize = game.getUpperListBuilding().size(); - int lowerBuildingSize = game.getLowerListBuilding().size(); - - List upperTribe = game.getUpperListTribeCards(); - List lowerTribe = game.getLowerListTribeCards(); - List upperBuilding = game.getUpperListBuilding(); - List lowerBuilding = game.getLowerListBuilding(); - - upperTribe.clear(); - lowerTribe.clear(); - upperBuilding.clear(); - lowerBuilding.clear(); - - assertEquals(upperTribeSize, game.getUpperListTribeCards().size()); - assertEquals(lowerTribeSize, game.getLowerListTribeCards().size()); - assertEquals(upperBuildingSize, game.getUpperListBuilding().size()); - assertEquals(lowerBuildingSize, game.getLowerListBuilding().size()); - } - @Test void getPlayersShouldReturnAddedPlayers() { Game game = new Game(3); @@ -1522,35 +1497,6 @@ class GameTest { fail("The test never reached a lower building draw state."); } - @Test - void cardListsShouldReturnClonedCards() { - Game game = new Game(3); - - List firstUpperTribeCall = game.getUpperListTribeCards(); - List secondUpperTribeCall = game.getUpperListTribeCards(); - - assertFalse(firstUpperTribeCall.isEmpty()); - assertFalse(secondUpperTribeCall.isEmpty()); - - assertNotSame(firstUpperTribeCall.get(0), secondUpperTribeCall.get(0)); - - List firstLowerTribeCall = game.getLowerListTribeCards(); - List secondLowerTribeCall = game.getLowerListTribeCards(); - - assertFalse(firstLowerTribeCall.isEmpty()); - assertFalse(secondLowerTribeCall.isEmpty()); - - assertNotSame(firstLowerTribeCall.get(0), secondLowerTribeCall.get(0)); - - List firstUpperBuildingCall = game.getUpperListBuilding(); - List secondUpperBuildingCall = game.getUpperListBuilding(); - - assertFalse(firstUpperBuildingCall.isEmpty()); - assertFalse(secondUpperBuildingCall.isEmpty()); - - assertNotSame(firstUpperBuildingCall.get(0), secondUpperBuildingCall.get(0)); - } - @Test void initShouldAssignInitialFoodAccordingToOrderPosition() { Game game = new Game(5); @@ -1590,6 +1536,24 @@ class GameTest { assertTrue(game.SlotChoiceByIndex(current, 0)); + for (int i = 1; i < game.getNPlayers(); i++) { + Player temp = game.getCurrentState().getCurrentPlayer(); + + assertTrue(game.SlotChoiceByIndex(temp, i)); + + assertTrue( + game.getSlotMap().values().stream() + .anyMatch(player -> player != null + && player.getUserName().equals(temp.getUserName())), + "The selected player should be present in the slot map." + ); + } + assertEquals(foodBefore + 6, current.getFoodValue()); + resolveAllMandatoryActions(game); + foodBefore = current.getFoodValue(); + + assertTrue(game.SlotChoiceByIndex(current, 0)); + for (int i = 1; i < game.getNPlayers(); i++) { Player temp = game.getCurrentState().getCurrentPlayer();